Add support for copy_ for plain layout and tensor core tiled layout (#1791) #1804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1804
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
drisspg
force-pushed
the
drisspg/stack/40
branch
from
37ee439 to
514f0cc
Compare
drisspg
pushed a commit
that referenced
this pull request
Feb 28, 2025
…1791) * Add support for copy_ for plain layout and tensor core tiled layout Summary: att, only support copy_ from AQT to another AQT with same metadata (shapes etc.) Tested int4wo, int8wo, int8dq Test Plan: python test/dtypes/test_affine_quantized.py -k test_copy_ Reviewers: Subscribers: Tasks: Tags: * remove print * add metadata mismatch test * rebase and add float8 * cutlass int4 support stack-info: PR: #1804, branch: drisspg/stack/40
facebook-github-bot
added
the
CLA Signed
drisspg
added
the
topic: not user facing
Contributor
Author
|
cc @metascroy is someone looking at the failing AO experimental tests? |
jerryzh168
approved these changes
Mar 1, 2025
Contributor
There was a problem hiding this comment.
thanks!
we need to skip "apply_quant = Int8DynamicActivationInt4WeightConfig(group_size=None, layout=CutlassInt4PackedLayout(), mapping_type=<MappingType.SYMMETRIC: 1>, act_mapping_type=<MappingType.SYMMETRIC: 1>)" I think
the experimental test failure might be a flaky test, it's not related to the PR I think
drisspg
force-pushed
the
drisspg/stack/40
branch
from
514f0cc to
18b7e16
Compare
This was referenced Mar 4, 2025
Closed
drisspg
pushed a commit
that referenced
this pull request
Mar 4, 2025
…1791) * Add support for copy_ for plain layout and tensor core tiled layout Summary: att, only support copy_ from AQT to another AQT with same metadata (shapes etc.) Tested int4wo, int8wo, int8dq Test Plan: python test/dtypes/test_affine_quantized.py -k test_copy_ Reviewers: Subscribers: Tasks: Tags: * remove print * add metadata mismatch test * rebase and add float8 * cutlass int4 support stack-info: PR: #1804, branch: drisspg/stack/40
drisspg
force-pushed
the
drisspg/stack/40
branch
2 times, most recently
from
dab1ead to
d790d7d
Compare
drisspg
pushed a commit
that referenced
this pull request
Mar 5, 2025
…1791) * Add support for copy_ for plain layout and tensor core tiled layout Summary: att, only support copy_ from AQT to another AQT with same metadata (shapes etc.) Tested int4wo, int8wo, int8dq Test Plan: python test/dtypes/test_affine_quantized.py -k test_copy_ Reviewers: Subscribers: Tasks: Tags: * remove print * add metadata mismatch test * rebase and add float8 * cutlass int4 support stack-info: PR: #1804, branch: drisspg/stack/40
drisspg
force-pushed
the
drisspg/stack/40
branch
from
d790d7d to
3a0fd37
Compare
…1791) * Add support for copy_ for plain layout and tensor core tiled layout Summary: att, only support copy_ from AQT to another AQT with same metadata (shapes etc.) Tested int4wo, int8wo, int8dq Test Plan: python test/dtypes/test_affine_quantized.py -k test_copy_ Reviewers: Subscribers: Tasks: Tags: * remove print * add metadata mismatch test * rebase and add float8 * cutlass int4 support stack-info: PR: #1804, branch: drisspg/stack/40
drisspg
force-pushed
the
drisspg/stack/40
branch
from
3a0fd37 to
45067de
Compare
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
…1791) (#1804) * Add support for copy_ for plain layout and tensor core tiled layout Summary: att, only support copy_ from AQT to another AQT with same metadata (shapes etc.) Tested int4wo, int8wo, int8dq Test Plan: python test/dtypes/test_affine_quantized.py -k test_copy_ Reviewers: Subscribers: Tasks: Tags: * remove print * add metadata mismatch test * rebase and add float8 * cutlass int4 support stack-info: PR: #1804, branch: drisspg/stack/40 Co-authored-by: Jerry Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Take two / running on ROCM to surface errors
Add support for copy_ for plain layout and tensor core tiled layout (#1791)
Summary:
att, only support copy_ from AQT to another AQT with same metadata (shapes etc.)
Tested int4wo, int8wo, int8dq
Test Plan:
python test/dtypes/test_affine_quantized.py -k test_copy_
Reviewers:
Subscribers:
Tasks:
Tags:
remove print
add metadata mismatch test
rebase and add float8
cutlass int4 support