Skip to content

Conversation

@jainapurva
Copy link
Contributor

Move torchao/_models to benchmarks/_models. The benchmarks folder will be main folder for all models and benchmarkings in AO

@jainapurva jainapurva added topic: bc-breaking Use this tag if this PR breaks backward compatibility topic: for developers Use this tag if this PR is mainly developer facing labels Feb 26, 2025
@jainapurva jainapurva requested a review from HDCharles February 26, 2025 05:50
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1784

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e88f03e with merge base 914de78 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 26, 2025
@jainapurva jainapurva removed the request for review from HDCharles February 26, 2025 07:10
@vkuzo
Copy link
Contributor

vkuzo commented Feb 26, 2025

btw, I don't think this is BC-breaking as this isn't a public API

@jainapurva jainapurva force-pushed the move_models branch 2 times, most recently from 78cd635 to 91e9d91 Compare February 27, 2025 19:08
@jainapurva jainapurva removed the topic: bc-breaking Use this tag if this PR breaks backward compatibility label Feb 27, 2025
@jainapurva jainapurva requested review from HDCharles, jerryzh168 and vkuzo and removed request for jerryzh168 and vkuzo February 27, 2025 22:51
@jainapurva jainapurva marked this pull request as ready for review March 4, 2025 05:24
@jainapurva jainapurva requested a review from jerryzh168 March 4, 2025 05:24
@jainapurva jainapurva merged commit 81a2813 into main Mar 4, 2025
17 checks passed
jainapurva added a commit that referenced this pull request Mar 5, 2025
jainapurva added a commit that referenced this pull request Mar 5, 2025
Revert "Move torchao/_models to benchmarks/_models (#1784)"

This reverts commit 81a2813.
liangel-02 pushed a commit that referenced this pull request Aug 25, 2025
Revert "Move torchao/_models to benchmarks/_models (#1784)"

This reverts commit 81a2813.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: for developers Use this tag if this PR is mainly developer facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants