Skip to content

roofline estimation: delete axiswise scaling, for now #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 27, 2025
Merged

roofline estimation: delete axiswise scaling, for now #1782

merged 12 commits into from
Feb 27, 2025

Conversation

@vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Feb 26, 2025

Summary:

This was not added correctly since it was reusing the tensorwise scaling
overhead estimates, deleting for now and we can add back later in a
cleaner way.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

vkuzo added 3 commits February 25, 2025 14:03
@vkuzo
Update
5b01edc 
[ghstack-poisoned]
@vkuzo
Update
0ae7f46 
[ghstack-poisoned]
@vkuzo
Update
77c8628 
[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Feb 26, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@vkuzo vkuzo mentioned this pull request Feb 26, 2025
Merged
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1782

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vkuzo vkuzo mentioned this pull request Feb 26, 2025
Merged
vkuzo added a commit that referenced this pull request Feb 26, 2025
@vkuzo
roofline estimation: delete axiswise scaling, for now
f5833fd 
Summary:

This was not added correctly since it was reusing the tensorwise scaling
overhead estimates, deleting for now and we can add back later in a
cleaner way.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: d9f2d1a
ghstack-comment-id: 2683596591
Pull Request resolved: #1782
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 26, 2025
@vkuzo vkuzo mentioned this pull request Feb 26, 2025
Merged
vkuzo added 3 commits February 26, 2025 10:34
@vkuzo
Update
00fb1b8 
[ghstack-poisoned]
@vkuzo
Update
64647f1 
[ghstack-poisoned]
@vkuzo
Update
4bed185 
[ghstack-poisoned]
@vkuzo vkuzo added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Feb 26, 2025
vkuzo added 3 commits February 26, 2025 15:59
@vkuzo
Update
73eec2e 
[ghstack-poisoned]
@vkuzo
Update
ac27fdd 
[ghstack-poisoned]
@vkuzo
Update
acc907a 
[ghstack-poisoned]
@vkuzo vkuzo mentioned this pull request Feb 26, 2025
Merged
vkuzo added 3 commits February 27, 2025 08:12
@vkuzo
Update
bf83a68 
[ghstack-poisoned]
@vkuzo
Update
400158b 
[ghstack-poisoned]
@vkuzo
Update
aa0abab 
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/43/head to main February 27, 2025 16:13
@vkuzo vkuzo merged commit cd69415 into main Feb 27, 2025
3 checks passed
liangel-02 pushed a commit that referenced this pull request Aug 25, 2025
@vkuzo @liangel-02
roofline estimation: delete axiswise scaling, for now (#1782)
dc3a1f4 
* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vkuzo @jerryzh168 @facebook-github-bot