Skip to content

Conversation

@crcrpar
Copy link
Contributor

@crcrpar crcrpar commented Feb 20, 2025

No description provided.

Signed-off-by: Masaki Kozuki <[email protected]>
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1740

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 20, 2025
Copy link
Contributor

@jainapurva jainapurva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@jainapurva jainapurva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on the latest main

@msaroufim msaroufim added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Mar 4, 2025
@msaroufim msaroufim merged commit 2c2a590 into pytorch:main Mar 4, 2025
9 of 16 checks passed
@crcrpar crcrpar deleted the typehint branch March 4, 2025 04:57
Jack-Khuu pushed a commit that referenced this pull request Mar 4, 2025
* update typehint

Signed-off-by: Masaki Kozuki <[email protected]>

* Update float8_linear_utils.py

---------

Signed-off-by: Masaki Kozuki <[email protected]>
Co-authored-by: Mark Saroufim <[email protected]>
liangel-02 pushed a commit that referenced this pull request Aug 25, 2025
* update typehint

Signed-off-by: Masaki Kozuki <[email protected]>

* Update float8_linear_utils.py

---------

Signed-off-by: Masaki Kozuki <[email protected]>
Co-authored-by: Mark Saroufim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants