Fix float8nocompile CI workflow #1695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielvegamyhre
added
ci
topic: not user facing
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1695
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3392076 with merge base 32a51ec ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
andrewor14
approved these changes
Mar 4, 2025
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
fix float8nocompile ci workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that I misinterpreted the example in this section of the Github actions docs and need to update this CI workflow accordingly.
The intent here is to ensure that the float8nocompile tests only run when code in
torchao/prototype/float8nocompile/changes. The removed line in the diff negates the previous line, so the result was the CI workflow never ran. Removing it will fix this.