Skip to content

Bug Fix (#1559): sparsity instead of sparstiy #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2025
Merged

Bug Fix (#1559): sparsity instead of sparstiy #1560

merged 1 commit into from
Jan 15, 2025

Conversation

jaewoosong
Copy link
Contributor 

  File "/home/workspace/ao/torchao/_models/llama/eval.py", line 348, in <module>
    args.sparstiy,
    ^^^^^^^^^^^^^
AttributeError: 'Namespace' object has no attribute 'sparstiy'. Did you mean: 'sparsity'?

The file ao/torchao/_models/llama/eval.py has a typo at line 348 which causes AttributeError.

This PR will fix the issue #1559

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 14, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1560

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 58527c2 with merge base de5c6e1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jaewoosong jaewoosong mentioned this pull request Jan 14, 2025
Closed
@jainapurva jainapurva added the topic: bug fix Use this tag for PRs that fix bugs label Jan 15, 2025
@jaewoosong
Copy link
Contributor Author

@jerryzh168 @jainapurva Thank you for your review and approval. There is one failing test in CI but it is not related to this PR. Would you please merge the PR?

@jainapurva jainapurva merged commit e1cb44a into pytorch:main Jan 15, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: bug fix Use this tag for PRs that fix bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaewoosong @jerryzh168 @facebook-github-bot @jainapurva