Use exp2 for mx scaling #1530
Merged
Use exp2 for mx scaling #1530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1530
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 5 PendingAs of commit e5383e1 with merge base ac832b0 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
drisspg
added a commit
that referenced
this pull request
Jan 9, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
drisspg
force-pushed
the
drisspg/stack/26
branch
from
29300f9 to
75587ff
Compare
facebook-github-bot
added
the
CLA Signed
drisspg
added a commit
that referenced
this pull request
Jan 9, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
drisspg
force-pushed
the
drisspg/stack/26
branch
from
75587ff to
a0db83c
Compare
drisspg
added a commit
that referenced
this pull request
Jan 9, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
drisspg
force-pushed
the
drisspg/stack/26
branch
from
a0db83c to
5bb2abf
Compare
drisspg
added a commit
that referenced
this pull request
Jan 9, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
drisspg
force-pushed
the
drisspg/stack/26
branch
from
5bb2abf to
ffef385
Compare
drisspg
added a commit
that referenced
this pull request
Jan 9, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
drisspg
force-pushed
the
drisspg/stack/26
branch
from
ffef385 to
71e43d3
Compare
vkuzo
reviewed
Jan 9, 2025
| torch.full(max_abs.size(), 2.0, device=scale_e8m0_biased.device), | ||
| scale_e8m0_unbiased, | ||
| ) | ||
| scale_fp = torch.exp2(scale_e8m0_unbiased).to(torch.float32) |
vkuzo
approved these changes
Jan 9, 2025
Contributor
|
should ensure CI is green though |
drisspg
added a commit
that referenced
this pull request
Jan 9, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
drisspg
force-pushed
the
drisspg/stack/26
branch
from
71e43d3 to
6238167
Compare
drisspg
added
the
topic: not user facing
drisspg
added a commit
that referenced
this pull request
Jan 15, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
drisspg
force-pushed
the
drisspg/stack/26
branch
from
6238167 to
9d068d5
Compare
Contributor
|
plans on landing this? |
Contributor
Author
|
Yeah I'll fix it up |
stack-info: PR: #1530, branch: drisspg/stack/26
drisspg
force-pushed
the
drisspg/stack/26
branch
from
9d068d5 to
e5383e1
Compare
jainapurva
added a commit
that referenced
this pull request
Mar 3, 2025
This reverts commit 890e0ac.
drisspg
pushed a commit
that referenced
this pull request
Mar 3, 2025
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Use exp2 for mx scaling