Skip to content

Conversation

@msaroufim
Copy link
Member

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1064

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 660a746 with merge base e6ceb95 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 12, 2024
@msaroufim msaroufim changed the title Test: Unpin CUDA Nightly Unpin CUDA Nightly Oct 12, 2024
@msaroufim msaroufim requested a review from jerryzh168 October 12, 2024 00:46
@msaroufim
Copy link
Member Author

msaroufim commented Oct 12, 2024

Yeah this test is reliably failing python test/prototype/test_quantized_training.py TestFSDP2.test_fsdp2_correctness

@gau-nernst
Copy link
Collaborator

I think it's due to this pytorch/pytorch#137005. Will push a fix

@awgu Sorry forgot to inform you, I already jumped ahead and used your new all gather extension signature 😅

@msaroufim msaroufim merged commit e7b33bc into main Oct 13, 2024
17 checks passed
jainapurva pushed a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants