Unskip test_choose_qparams_token_asym in 2.6
#1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1004
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit dd9b5f1 with merge base 0ffbf85 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Member
|
Because of the upstream IMA issues on the nightly job we can't possibly have signal for this without fixing the upstream issue |
Summary: Fixes: pytorch#970 The test was broken by a recent refactor in pytorch: pytorch/pytorch#136807 Test Plan: CI Reviewers: Subscribers: Tasks: Tags:
jerryzh168
force-pushed
the
unskip-choose-qparams
branch
from
f3d1c3b to
dd9b5f1
Compare
msaroufim
approved these changes
Oct 4, 2024
melvinebenezer
pushed a commit
to melvinebenezer/ao
that referenced
this pull request
Oct 7, 2024
* Unskip `test_choose_qparams_token_asym` in 2.6 Summary: Fixes: pytorch#970 The test was broken by a recent refactor in pytorch: pytorch/pytorch#136807 Test Plan: CI Reviewers: Subscribers: Tasks: Tags: * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes: #970
The test was broken by a recent refactor in pytorch: pytorch/pytorch#136807
Test Plan:
CI
Reviewers:
Subscribers:
Tasks:
Tags: