Skip to content

feat: support aten.flip dynamo converter #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 15, 2024
Merged

feat: support aten.flip dynamo converter #2540

merged 3 commits into from
Jan 15, 2024

Conversation

zewenli98
Copy link
Collaborator

Description

Support aten.flip dynamo converter.

Fixes #2535

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Dec 14, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests labels Dec 14, 2023
@github-actions github-actions bot requested a review from peri044 December 14, 2023 04:34
@gs-olive gs-olive self-requested a review December 15, 2023 18:58
gs-olive
gs-olive reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions, otherwise looks good!

@zewenli98 zewenli98 requested a review from gs-olive December 18, 2023 22:47
gs-olive
gs-olive approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor suggestion for an additional test case. Otherwise looks good to me!

@zewenli98 zewenli98 force-pushed the flip_dynamo_converter branch from b0e4e5c to 2dead01 Compare January 15, 2024 17:17
@zewenli98 zewenli98 merged commit fd19353 into pytorch:main Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 Awaiting requested review from peri044

1 more reviewer

@gs-olive gs-olive gs-olive approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@zewenli98 zewenli98

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aten.flip
3 participants
@zewenli98 @gs-olive @facebook-github-bot