Skip to content

Conversation

anniesurla
Copy link

@anniesurla anniesurla commented Aug 4, 2022

Description

Added an example notebook to demonstrate the workflow of PTQ and QAT using Torch-TensorRT

Type of change

-New Example

@facebook-github-bot
Copy link
Contributor

Hi @anniesurla!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO even if it results in a more verbose notebook it's better to have all the necessary code in the notebook instead of shipping a utility file as well because this makes it harder for someone to pull the notebook out of the repo and run it independently. Notebooks should try to be as self contained as possible

@anniesurla
Copy link
Author

@narendasan Davide suggested Tanay upload the notebook since the CLA process can take sometime. Since Tanay is all set as contributor, he will be uploading this on my behalf. You can however suggest all changes, I will make them accordingly, and when ready, Tanay will submit a new PR.

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, feel free to close and have @tanayvarshney open a PR from this branch

@narendasan
Copy link
Collaborator

Merged in #1239

@narendasan narendasan closed this Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants