Skip to content

refactor: remove the code that covers the no output segmented block #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

refactor: remove the code that covers the no output segmented block #1174

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5259269
refactor: remove the code that covers the no output segmented block c…
bowang007 Jul 12, 2022
297d62e
Merge branch 'master' into delete_remove_nodes
peri044 Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 3 additions & 22 deletions core/partitioning/partitioning.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,34 +181,15 @@ void registerSegmentsOutputs(PartitionedGraph& segmented_blocks, torch::jit::Blo
seg_block.registerOutput(mini_graph_input);
}
}
// if no output, then register the last node's output as current graph's output
// if no output, then register this graph's input as its output
// We can ensure that TRT segmented block has Tensor inputs now
if (seg_block.raw_outputs().empty()) {
// for Torch segments, register input as output
if (seg_block.target() == SegmentedBlock::kTorch) {
seg_block.registerOutput(seg_block.raw_inputs()[0]);
} else {
// for TensorRT segments, register last nonInput Tensor outputs
for (int i = seg_block.raw_nodes().size() - 1; i >= 0; --i) {
for (auto node_output : seg_block.raw_nodes()[i]->outputs()) {
if (isTensor(node_output))
seg_block.registerOutput(node_output);
}
if (!seg_block.raw_outputs().empty())
break;
}
}
seg_block.registerOutput(seg_block.raw_inputs()[0]);
}
}
std::for_each(segmented_blocks.begin(), segmented_blocks.end(), [](SegmentedBlock& seg_block) {
torch::jit::EliminateDeadCode(seg_block.g());
});
// erase segments which still have no output
segmented_blocks.erase(
std::remove_if(
segmented_blocks.begin(),
segmented_blocks.end(),
[](SegmentedBlock& seg_block) { return seg_block.raw_outputs().empty(); }),
segmented_blocks.end());

return;
}
Expand Down