Skip to content

Conversation

inocsin
Copy link
Contributor

@inocsin inocsin commented Jun 13, 2022

Signed-off-by: inocsin [email protected]

Description

Support aten::slice with dynamic shape

Fixes #945 #1087

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests labels Jun 13, 2022
@inocsin
Copy link
Contributor Author

inocsin commented Jun 13, 2022

@narendasan please review this PR

@inocsin
Copy link
Contributor Author

inocsin commented Jun 29, 2022

@narendasan updated the code

@ncomly-nvidia ncomly-nvidia added the release: v1.2 Tagged to be included in v1.2 label Jul 11, 2022
@github-actions github-actions bot requested a review from narendasan July 11, 2022 20:58
@peri044 peri044 merged commit d3041f5 into pytorch:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests release: v1.2 Tagged to be included in v1.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [Bug] RuntimeError: [Error thrown at core/conversion/converters/impl/select.cpp:236] Expected const_layer to be true but got false

6 participants