fix gpu device bug in split_table_batched_embeddings_benchmark #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Bug in get_device() function, where on a gpu machine (torch.cuda.is_available() == True) it returns torch.cuda.current_device instead of torch.cuda.current_device(). Therefore the return value for get_device() ends up being a function rather than a torch.device, causing the benchmark to crash at the first instance of device placement based on get_device(). Reviewed By: bilgeacun, jianyuh Differential Revision: D27606621 fbshipit-source-id: 46445d77118990686fff4becca221d89279d6d6d
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D27606621 |
Contributor
|
This pull request has been merged in b01c349. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Bug in get_device() function, where on a gpu machine (torch.cuda.is_available() == True) it returns torch.cuda.current_device instead of torch.cuda.current_device(). Therefore the return value for get_device() ends up being a function rather than a torch.device, causing the benchmark to crash at the first instance of device placement based on get_device().
Reviewed By: bilgeacun, jianyuh
Differential Revision: D27606621