shortcut for merge_pooled_embedding #5147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Summary: X-link: facebookresearch/FBGEMM#2146 att. When all the input embedding are from the same device, we can just use cat as a short cut. This can avoid unnecessary cross device sync with current impl. Differential Revision: D87306514
garroud
force-pushed
the
export-D87306514
branch
from
2923827 to
72fa5fe
Compare
Contributor
|
This pull request has been merged in 7826ec9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/2146
att. When all the input embedding are from the same device, we can just use cat as a short cut. This can avoid unnecessary cross device sync with current impl.
Differential Revision: D87306514