Extend raw_id_tracker to track ShardedManagedCollisionEmbeddingCollection #5128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@FriedCosey has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87018676. |
FriedCosey
pushed a commit
to FriedCosey/torchrec
that referenced
this pull request
Nov 14, 2025
…tion Summary: X-link: pytorch/FBGEMM#5128 This diff extends `raw_id_tracker` to support both `ShardedManagedCollisionEmbeddingCollection` and `ShardedManagedCollisionEmbeddingBagCollection`. To avoid code duplication, the diff refactors the initialization and identity parsing logic into the `BaseEmbedding` class. Differential Revision: D87018676
FriedCosey
pushed a commit
to FriedCosey/torchrec
that referenced
this pull request
Nov 14, 2025
…tion (meta-pytorch#3545) Summary: X-link: facebookresearch/FBGEMM#2131 X-link: pytorch/FBGEMM#5128 This diff extends `raw_id_tracker` to support both `ShardedManagedCollisionEmbeddingCollection` and `ShardedManagedCollisionEmbeddingBagCollection`. To avoid code duplication, the diff refactors the initialization and identity parsing logic into the `BaseEmbedding` class. Differential Revision: D87018676
FriedCosey
force-pushed
the
export-D87018676
branch
from
e8451c7 to
cb62d16
Compare
…agsCodegen Differential Revision: D87089649
FriedCosey
pushed a commit
to FriedCosey/torchrec
that referenced
this pull request
Nov 17, 2025
…tion (meta-pytorch#3545) Summary: X-link: facebookresearch/FBGEMM#2131 X-link: pytorch/FBGEMM#5128 This diff extends `raw_id_tracker` to support both `ShardedManagedCollisionEmbeddingCollection` and `ShardedManagedCollisionEmbeddingBagCollection`. To avoid code duplication, the diff refactors the initialization and identity parsing logic into the `BaseEmbedding` class. Reviewed By: chouxi, aliafzal Differential Revision: D87018676
FriedCosey
force-pushed
the
export-D87018676
branch
from
cb62d16 to
7c1a4de
Compare
meta-codesync bot
pushed a commit
to meta-pytorch/torchrec
that referenced
this pull request
Nov 18, 2025
…tion (#3545) Summary: Pull Request resolved: #3545 X-link: https://github.com/facebookresearch/FBGEMM/pull/2131 X-link: pytorch/FBGEMM#5128 This diff extends `raw_id_tracker` to support both `ShardedManagedCollisionEmbeddingCollection` and `ShardedManagedCollisionEmbeddingBagCollection`. To avoid code duplication, the diff refactors the initialization and identity parsing logic into the `BaseEmbedding` class. Reviewed By: chouxi, aliafzal Differential Revision: D87018676 fbshipit-source-id: fa3a7cce98d5bacdceb276efbe1d153d797969e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff extends
raw_id_trackerto support bothShardedManagedCollisionEmbeddingCollectionandShardedManagedCollisionEmbeddingBagCollection. To avoid code duplication, the diff refactors the initialization and identity parsing logic into theBaseEmbeddingclass.Differential Revision: D87018676