Backward optimization for group_index_select_or_add_2d_kernel #5123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
spcyppt
reviewed
Nov 18, 2025
| num_cols = num_cols_group[0]; | ||
| warps_per_row = (num_cols + COLS_PER_WARP - 1) >> LOG_COLS_PER_WARP; | ||
| } | ||
| // USE_INDEX_SELECT is a template argument; the compiler prunes the unused branch. |
Contributor
There was a problem hiding this comment.
Please guard all the changes to be ROCm only. We have benchmarked and this regressed NVIDIA's.
Author
There was a problem hiding this comment.
Added the original code and guarded the current changes in 76b963d
shbiswas834
force-pushed
the
shbiswas/group_index_bwd
branch
from
4f41fdf to
1f28387
Compare
shbiswas834
force-pushed
the
shbiswas/group_index_bwd
branch
from
1f28387 to
1063c0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.