Last fixups before release #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(after you fix the failing test) |
|
Thanks. The failing tests have to do with python3 and the bytes/strings/unicode nonsense. It interacts very poorly with the base64 module. |
|
Yep, I know, I had 'fun' back in the time maing jwcrypto tests.py work in both python2 and python3, look at that one for inspiration if you need some :) |
This wasn't needed for requests-kerberos because pykerberos automatically base64 encodes and decodes messages from Kerberos, which is a behavior I do not like at all. Signed-off-by: Robbie Harwood <[email protected]>
Signed-off-by: Robbie Harwood <[email protected]>
Signed-off-by: Robbie Harwood <[email protected]> Resolves: pythongssapi#5
frozencemetery
force-pushed
the
mag_success
branch
from
9ee984a to
4092b2d
Compare
|
Thanks. Should be good to go now I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were encountered when running the mod_auth_gssapi test suite against the shim interface. I replaced all
import requests_kerberosthere withimport requests_gssapiand performed no other action, so it tested only the shim interface. It may be good to add a CI item for doing this on a regular basis going forward.Also this is the last thing on my TODO list before release.