Skip to content

Add frozen_default parameter on dataclass_transform #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2022
Merged

Add frozen_default parameter on dataclass_transform #101

merged 1 commit into from
Dec 3, 2022

Conversation

@debonte
Copy link
Contributor

@debonte debonte commented Dec 3, 2022

Mirroring the typing.py change at python/cpython#99958.

@JelleZijlstra

hauntsaninja
hauntsaninja approved these changes Dec 3, 2022
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Jelle didn't have any typing-extensions relevant feedback on the CPython PR, so I'll go ahead and merge :-)

@hauntsaninja hauntsaninja merged commit 57226b4 into python:main Dec 3, 2022
@debonte debonte deleted the frozen_default branch December 3, 2022 05:09
@NeilGirdhar NeilGirdhar mentioned this pull request Dec 14, 2022
Closed
@hegjon hegjon mentioned this pull request Jan 31, 2023
Closed
@NeilGirdhar NeilGirdhar mentioned this pull request Feb 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@debonte @hauntsaninja