Add reportMissingParameterType to pyrightconfig.stricter.json
#8770
Conversation
This comment has been minimized.
This comment has been minimized.
| replace_paths=..., | ||
| implies=..., | ||
| graph: Incomplete | None = ..., | ||
| user_hook_dirs: Iterable[StrOrBytesPath] = ..., |
There was a problem hiding this comment.
Bytes paths don't work: PyInstaller.depend.analysis.PyiModuleGraph("x", [b"y"]) throws a TypeError.
There was a problem hiding this comment.
TypeError: Can't mix strings and bytes in path components
This is probably the case in other parts of the stubs as well 😓 I'll go back through other StrOrBytesPath and make a PR to fix them when they're explicitly used with strings.
| graph: Incomplete | None = ..., | ||
| user_hook_dirs: Iterable[StrOrBytesPath] = ..., | ||
| excludes: Iterable[str] = ..., | ||
| path: Iterable[str] | None = ..., |
There was a problem hiding this comment.
These and further args are keyword-only, since they're forwarded through **kwargs.
There was a problem hiding this comment.
Didn't know keyword-only arguments were a thing. Thanks!
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looks good now, thanks!
Your other PR introduced a few conflicts, I hope I got the merge right.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
2 participants
This was noticed in #8702 (comment)
Completes the types in keyboard and PyInstaller (which I've both added recently) so that this option can be turned on.