Skip to content

Conversation

@AlexWaygood
Copy link
Member

A hack that might fix #7019

@AlexWaygood AlexWaygood marked this pull request as ready for review January 24, 2022 11:20
@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 6346464 into python:master Jan 24, 2022
@AlexWaygood AlexWaygood deleted the patch-1 branch January 24, 2022 12:29
@Akuli
Copy link
Collaborator

Akuli commented Jan 24, 2022

I have found mypy's "Cannot determine type" errors to be unpredictable and weird in the past. I once tried bisecting one of them, and it turned out to exist even in the oldest mypy versions I could get to run.

AlexWaygood added a commit that referenced this pull request Mar 24, 2022
Let's see if this is fixed in mypy 0.942.

This reverts the changes made in #7022, which was a hack to fix #7019
JelleZijlstra pushed a commit that referenced this pull request Mar 24, 2022
Let's see if this is fixed in mypy 0.942.

This reverts the changes made in #7022, which was a hack to fix #7019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mypy is failing on the stdlib

3 participants