paramiko: Change dependencies on types-cryptography, allow using upstream type hints
#5847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since version 3.4, the cryptography library itself ships with type hints: https://cryptography.io/en/latest/changelog/#v3-4 This is the first step for removing types-cryptography. Currently, if I use `types-paramiko` and `cryptography`, it forces me to use `types-cryptography` as well. It should be up to the end-user to decide if they want upstream hints or from typeshed. As discussed in the removal issue, I have added a dependency on `types-paramiko` -> `cryptography` and `types-pyOpenSSL` -> `cryptography`.
intgr
changed the title
Contributor
Author
|
Ping @srittau? |
Collaborator
|
This needs a bit more infrastructure work in typeshed. Currently, our tests don't install the dependencies from |
JelleZijlstra
added
the
status: deferred
AlexWaygood
changed the title
paramiko: Change dependencies on types-cryptography, allow using upstream type hints
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Member
Contributor
Author
|
Thanks! Better late than never 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 3.4, the cryptography library itself ships with type hints: https://cryptography.io/en/latest/changelog/#v3-4
This is the first step for #5618. Currently, if I use
types-paramikoandcryptography, it forces me to usetypes-cryptographyas well. It should be up to the end-user to decide if they want upstream hints or from typeshed.As discussed in #5618 and #5768, I have replaced it with a dependency on
types-paramiko->cryptographyandtypes-pyOpenSSL->cryptography.