fix the return type of bdb.Bdb.runeval
#15049
Conversation
|
maybe more explicitly this should be |
yeah, that looks like dead code to me... maybe it's worth adding a comment to the stub? At first glance the runtime implementation definitely looks like it could return |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
| self, cmd: str | CodeType, globals: dict[str, Any] | None = None, locals: Mapping[str, Any] | None = None | ||
| ) -> None: ... | ||
| def runeval(self, expr: str, globals: dict[str, Any] | None = None, locals: Mapping[str, Any] | None = None) -> None: ... | ||
| def runeval(self, expr: str, globals: dict[str, Any] | None = None, locals: Mapping[str, Any] | None = None) -> Any: ... |
There was a problem hiding this comment.
We also need a comment describing the Any:
| def runeval(self, expr: str, globals: dict[str, Any] | None = None, locals: Mapping[str, Any] | None = None) -> Any: ... | |
| # Returns the value of the evaluated expression. | |
| def runeval(self, expr: str, globals: dict[str, Any] | None = None, locals: Mapping[str, Any] | None = None) -> Any: ... |
(The globals and locals dict/Mapping are common, obvious expressions and don't need a comment.)
There was a problem hiding this comment.
in a twist of irony the signature of eval actually does the opposite -- the comment describes globals and not the return value -- this is just matching the signature of eval which is maybe a better comment? (but I guess then it should be locals: Mapping[str, object]?)
3 participants
https://github.com/python/cpython/blob/daafacf0053e9c329b0f96447258f628dd0bd6f1/Lib/bdb.py#L924