Skip to content

Conversation

donBarbos
Copy link
Contributor

Closes: #14697

protocol: str = "https",
rest_options: RestClientOptions | None = None,
) -> None: ...
def all(self, page: int = 0, per_page: int = 25, include_totals: bool = True) -> list[dict[str, Incomplete]]: ...
Copy link
Contributor Author

@donBarbos donBarbos Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR: I used dict[str, Incomplete] even though the source code uses dict[str, Any] because this approach is also used in other types for these stubs

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

# Inconsistently implemented, ommitted
auth0\.management\.Auth0\..*

# See https://github.com/auth0/auth0-python/issues/732
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# See https://github.com/auth0/auth0-python/issues/732
# Runtime __all__ lists "NetworkAclsOrganizations" instead of "NetworkAcls"
# and "Organizations" due to a missing comma in the definition
# See https://github.com/auth0/auth0-python/issues/732

Comment on lines +54 to 55
"NetworkAcls",
"Organizations",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally sure what what's best to include here given auth0/auth0-python#732.

I guess one alternative would be to hold off updating the stubs until auth0-python fixes the __all__ issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind waiting for the library to be updated if they don't change semantic version.
For now we can leave it as is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants