-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[auth0-python] Update to 4.11.* #14704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
protocol: str = "https", | ||
rest_options: RestClientOptions | None = None, | ||
) -> None: ... | ||
def all(self, page: int = 0, per_page: int = 25, include_totals: bool = True) -> list[dict[str, Incomplete]]: ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR: I used dict[str, Incomplete]
even though the source code uses dict[str, Any]
because this approach is also used in other types for these stubs
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
# Inconsistently implemented, ommitted | ||
auth0\.management\.Auth0\..* | ||
|
||
# See https://github.com/auth0/auth0-python/issues/732 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# See https://github.com/auth0/auth0-python/issues/732 | |
# Runtime __all__ lists "NetworkAclsOrganizations" instead of "NetworkAcls" | |
# and "Organizations" due to a missing comma in the definition | |
# See https://github.com/auth0/auth0-python/issues/732 |
"NetworkAcls", | ||
"Organizations", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not totally sure what what's best to include here given auth0/auth0-python#732.
I guess one alternative would be to hold off updating the stubs until auth0-python fixes the __all__
issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind waiting for the library to be updated if they don't change semantic version.
For now we can leave it as is
Closes: #14697