Skip to content

Conversation

@donbarbos
Copy link
Contributor

@donbarbos donbarbos commented Mar 18, 2025

related #13640


Deferred: Waiting for upstream 3.13 support: TeskaLabs/cysimdjson#55

@donbarbos
Copy link
Contributor Author

donbarbos commented Mar 18, 2025

Should I changed version in METADATA.toml to "24.12"?
create_baseline_stubs.py script set it to "24.12.*"

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@brianschubert
Copy link
Collaborator

Looks like stubtest failure is due to cysimdjson not supporting Python 3.13

@donbarbos
Copy link
Contributor Author

Looks like stubtest failure is due to cysimdjson not supporting Python 3.13

Tests fail only on ubuntu, but windows and macos also use python 3.13

@brianschubert
Copy link
Collaborator

stubtest only runs on linux by default. Windows/macos need to be requested by setting platforms in METADATA.toml (only necessary if a stub has platform specific branches, which this stub does not).

The linux run failed because stubtest is running on Python 3.13 but the latest release of cysimdjson only provides wheels for Python 3.12 and below: https://pypi.org/project/cysimdjson/24.12/#files

@srittau
Copy link
Collaborator

srittau commented Mar 19, 2025

There was a ticket here about 3.13 support: TeskaLabs/cysimdjson#55, which got no reply so far. In principle I'm okay with adding these stubs, but at least for the initial commit I'd like to have stubtest support. Maybe @ateska can clarify whether cysimdjson is still supported and 3.13 wheels are planned?

@ateska
Copy link

ateska commented Mar 19, 2025

Hi,
Yes, we will release the version that supports Python 3.13 - thanks for the heads up.

@srittau srittau added the status: deferred Issue or PR deferred until some precondition is fixed label Mar 19, 2025
@srittau
Copy link
Collaborator

srittau commented Mar 19, 2025

Should I changed version in METADATA.toml to "24.12"? create_baseline_stubs.py script set it to "24.12.*"

Yes, using 24.12 was a good idea in this instance, since the library doesn't use semantic versioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: deferred Issue or PR deferred until some precondition is fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants