Skip to content

Conversation

@pyhedgehog
Copy link
Contributor

No description provided.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@pyhedgehog
Copy link
Contributor Author

pyhedgehog commented Dec 11, 2024

According to mypy_primer, this change has no effect on the checked open source code.

Is this positive or negative reaction?

@JelleZijlstra
Copy link
Member

Is this positive or negative reaction?

Sort of neither. We check a corpus of open source code to check whether the PR leads to any changes in type checking. In this case, it didn't, most likely because none of the codebases checked use click-log.

@JelleZijlstra JelleZijlstra merged commit 2c27933 into python:main Dec 28, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants