Skip to content

Conversation

@ZivRonen
Copy link
Contributor

@ZivRonen ZivRonen commented Jul 2, 2024

see issue: #12259

@ZivRonen
Copy link
Contributor Author

ZivRonen commented Jul 2, 2024

I see that other stubs also use the python3.10 syntax of TYPE | None instead of optional, so I guess that mypy support it even for python3.8 on .pyi files and I use that convention as well.

Edit: Missed the Supported type system features part of the CONTRIBUTING.md. The more you know.

@ZivRonen
Copy link
Contributor Author

ZivRonen commented Jul 2, 2024

I used overload incorrectly. I will update it again in a moment, just wanted to upload a semi-working version to check that I understood the error

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra JelleZijlstra merged commit 2ea26f7 into python:main Jul 4, 2024
max-muoto pushed a commit to max-muoto/typeshed that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants