Merge uuid module into 2and3 #1148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
requested changes
Apr 8, 2017
stdlib/2and3/uuid.pyi
Outdated
| fields: Optional[_FieldsType] = ..., | ||
| int: Optional[_Int] = ..., | ||
| version: Optional[_Int] = ...) -> None: ... | ||
|
|
Member
There was a problem hiding this comment.
remove the blank lines between the properties
stdlib/2and3/uuid.pyi
Outdated
| def variant(self) -> str: ... | ||
|
|
||
| @property | ||
| def version(self) -> str: ... |
stdlib/2and3/uuid.pyi
Outdated
| def get_node(self) -> _Int: ... | ||
| def get_hex(self) -> str: ... | ||
| def get_urn(self) -> str: ... | ||
| def get_variant(self) -> _Int: ... |
stdlib/2and3/uuid.pyi
Outdated
| def get_version(self) -> _Int: ... | ||
|
|
||
| def getnode() -> int: ... | ||
| def uuid1(node: int = ..., clock_seq: int = ...) -> UUID: ... |
Member
There was a problem hiding this comment.
Both arguments are Optional
JelleZijlstra
approved these changes
Apr 10, 2017
Member
|
I messed up, should have waited for CI to finish. Fixing now. |
JelleZijlstra
added a commit
to JelleZijlstra/typeshed
that referenced
this pull request
Apr 10, 2017
Merged
JelleZijlstra
added a commit
that referenced
this pull request
Apr 10, 2017
hswong3i
pushed a commit
to alvistack/python-typeshed
that referenced
this pull request
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big difference is that the python2 version has methods called
get_XXX.