Skip to content

Add aware_datetime option to plistlib functions #11276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

aisk
Copy link
Member

@aisk aisk commented Jan 15, 2024

Since python/cpython#113363 and python/cpython#113582 have been merged, the plistlib module in upcoming Python3.13 release, will have a new optional parameter aware_datetime in most of it's functions.

In addition, the plistlib.loads also accepts str type as inputs value.

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@aisk
Copy link
Member Author

aisk commented Jan 15, 2024

The failed CI check https://github.com/python/typeshed/actions/runs/7528137651/job/20489713547?pr=11276 should not related to this change.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Ideally, we'd have overloads to allow a str value only if fmt is FMT_XML, but this will do for now.

@srittau
Copy link
Collaborator

srittau commented Jan 15, 2024

(The CI failure is unrelated.)

@srittau srittau merged commit 5367bab into python:main Jan 15, 2024
@aisk aisk deleted the plist-3.13 branch January 15, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants