-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
PEP 738: Mark as Final #3982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
PEP 738: Mark as Final #3982
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a8bc376
Finalize PEP 738, and add Android to PEP 11
mhsmith 3e69247
Change canonical-doc target to py3.14
mhsmith 0a2e704
Explain changes to specification of platform.android_ver
mhsmith 9f05d83
Change canonical-doc target to `python:using-android`
mhsmith a3ffa3a
Revert PEP 11 changes
mhsmith c6f9b84
Merge branch 'main' into android-final
AA-Turner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,12 +3,14 @@ Title: Adding Android as a supported platform | |
Author: Malcolm Smith <[email protected]> | ||
Sponsor: Petr Viktorin <[email protected]> | ||
Discussions-To: https://discuss.python.org/t/pep-738-adding-android-as-a-supported-platform/40975 | ||
Status: Accepted | ||
Status: Final | ||
Type: Standards Track | ||
Created: 12-Dec-2023 | ||
Python-Version: 3.13 | ||
Resolution: https://discuss.python.org/t/pep-738-adding-android-as-a-supported-platform/40975/23 | ||
|
||
.. canonical-doc:: :ref:`python:using-android` | ||
|
||
|
||
Abstract | ||
======== | ||
|
@@ -289,8 +291,6 @@ namedtuple containing the following: | |
* ``release`` - Android version of the device, as a string (e.g. ``"14"``) | ||
* ``api_level`` - :ref:`API level <738-os-versions>` of the device, as an | ||
integer (e.g. ``34``) | ||
* ``min_api_level`` - Minimum API level this build of Python can run on, as | ||
an integer (e.g. ``23``). This is the same as ``sys.getandroidapilevel``. | ||
* ``manufacturer`` - `manufacturer | ||
<https://developer.android.com/reference/android/os/Build#MANUFACTURER>`__ of | ||
the device, as a string (e.g. ``"Google"``) | ||
|
@@ -300,6 +300,8 @@ namedtuple containing the following: | |
* ``device`` - `device name | ||
<https://developer.android.com/reference/android/os/Build#DEVICE>`__ of the | ||
device, as a string (e.g. ``"panther"``) | ||
* ``is_emulator`` - ``True`` if the device is an emulator; ``False`` if it’s a | ||
physical device. | ||
AA-Turner marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Which one of ``model`` and ``device`` is more likely to be unique, and which one | ||
is more likely to resemble the marketing name, varies between different | ||
|
@@ -437,6 +439,20 @@ example of a test suite that is executed on the Android emulator using GitHub | |
Actions. | ||
|
||
|
||
Rejected Ideas | ||
============== | ||
|
||
The following changes were made to the original specification of | ||
``platform.android_ver()``: | ||
|
||
* The ``min_api_level`` field was removed, because unlike all the other fields, | ||
it isn't a property of the current device. This information is still available | ||
from the pre-existing function ``sys.getandroidapilevel()``. | ||
|
||
* The ``is_emulator`` field was added, since experience during testing showed | ||
that some issues were emulator-specific. | ||
|
||
|
||
Copyright | ||
========= | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.