Skip to content

PEP 590: Mark the main API as private to allow changes in Python 3.9 #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 28, 2019
Merged

PEP 590: Mark the main API as private to allow changes in Python 3.9 #1064

merged 5 commits into from
May 28, 2019

Conversation

@encukou
Copy link
Member

@encukou encukou commented May 21, 2019

@encukou encukou mentioned this pull request May 21, 2019
Closed
jdemeyer
jdemeyer reviewed May 21, 2019
View reviewed changes
@jdemeyer
Copy link
Contributor

jdemeyer commented May 21, 2019

_vectorcallfunc really should be private too.

@encukou
Copy link
Member Author

encukou commented May 21, 2019

vectorcallfunc is only usable with _Py_TPFLAGS_HAVE_VECTORCALL, so users will get the warning that they're using unfinalized API. I don't think it needs to be underscore-prefixed.

jdemeyer
jdemeyer reviewed May 21, 2019
View reviewed changes
@jdemeyer
Copy link
Contributor

jdemeyer commented May 21, 2019

vectorcallfunc is only usable with _Py_TPFLAGS_HAVE_VECTORCALL, so users will get the warning that they're using unfinalized API. I don't think it needs to be underscore-prefixed.

OK, I see what you mean.

jdemeyer
jdemeyer reviewed May 21, 2019
View reviewed changes
jdemeyer
jdemeyer reviewed May 21, 2019
View reviewed changes
jdemeyer
jdemeyer reviewed May 21, 2019
View reviewed changes
jdemeyer
jdemeyer reviewed May 21, 2019
View reviewed changes
@jdemeyer
Copy link
Contributor

jdemeyer commented May 21, 2019

I have no further comments.

@encukou encukou requested a review from markshannon May 21, 2019 10:25
@jdemeyer jdemeyer mentioned this pull request May 21, 2019
Merged
@encukou encukou merged commit 8363d1f into python:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pfmoore pfmoore pfmoore left review comments

@jdemeyer jdemeyer jdemeyer left review comments

@markshannon markshannon Awaiting requested review from markshannon

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@encukou @jdemeyer @pfmoore @the-knights-who-say-ni