stubtest: workaround mypyc's issue with vars #8411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
approved these changes
Feb 18, 2020
Collaborator
msullivan
left a comment
msullivan
left a comment
There was a problem hiding this comment.
We could get it working by sticking MaybeMissing[whatever] in quotes everywhere which wouldn't be too bad but it also isn't too important to compile this anyway.
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #8380
Thanks for the fix! The cast works, but unfortunately we have one last issue: mypyc does not like the conditional definitions necessary to work around a bug in Python 3.5.2 and earlier (8fda109). Example stacktrace here: https://travis-ci.org/hauntsaninja/mypy/jobs/651008763
Long story short, this PR doesn't do anything, but maybe it will in the future!