PEP 570: Positional-Only Arguments #6900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
May 30, 2019
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Thanks for implementing this! This gets us closer to Python 3.8 compatibility.
Looks good, just one idea for a test case.
| f(arg="ERROR") # E: Unexpected keyword argument "arg" for "f" | ||
|
|
||
| [case testPEP570Signatures1-skip] | ||
| def f(p1: bytes, p2: float, /, p_or_kw: int, *, kw: str) -> None: |
Collaborator
There was a problem hiding this comment.
Try also calling f with valid and invalid arguments. For example, make sure p1 is not a valid keyword argument but p_or_kw is both a valid positional and keyword argument, and kw must be a keyword argument.
Member
Author
|
Thanks for the suggestion @JukkaL! I've included the new test in my patch. |
Collaborator
|
I verified manually that the tests pass on Python 3.8a4. |
ilevkivskyi
pushed a commit
that referenced
this pull request
Jun 2, 2019
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
Fixes python#6878. This was actually much more straightforward than I anticipated; since we already support `__some` forms of positional-only arguments, it was just a matter of adding a couple of lines to properly pick up the new `posonlyargs` attribute from the AST. Skip PEP 570 tests until Travis supports 3.8.0a4+.
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
The `3.8-dev` Travis build environment now uses Python 3.8.0a4+! This is left over from python#6900. We aren't running 3.8 test right now for other reasons, but I've confirmed that these pass fine on my local build (@JukkaL confirmed too in the PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6878. This was actually much more straightforward than I anticipated; since we already support
__someforms of positional-only arguments, it was just a matter of adding a couple of lines to properly pick up the newposonlyargsattribute from the AST.The tricky part is the tests. Travis doesn't currently have any build environments for 3.8.0a4 (even the
python: "nightly"image is only 3.8.0a3+... 😐), so these tests fail with syntax errors. I've skipped them for now, but they pass fine on my local Python build. I added a small check intestcheck.pythat will emit a warning when it's safe to unskip these tests.