Speed up mypy startup by avoiding imports #6127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
approved these changes
Jan 2, 2019
Collaborator
msullivan
left a comment
msullivan
left a comment
There was a problem hiding this comment.
I love startup speedups!
|
|
||
|
|
||
| def get_class_descriptors(cls: 'Type[object]') -> Sequence[str]: | ||
| import inspect # Lazy import for minor startup speed win |
Collaborator
There was a problem hiding this comment.
What were you timing? I think get_class_descriptors is unfortunately actually on the path for a lot of stuff, even not the daemon, so I suspect this won't speed up real workloads? Though I'm not sure.
Collaborator
Author
There was a problem hiding this comment.
I might have been timing mypy --help for this. I timed other changes by type checking a small program. Since this is a very small change I think it's okay to keep it even if it doesn't help in any realistic scenarios.
|
|
||
| def write_junit_xml(dt: float, serious: bool, messages: List[str], path: str) -> None: | ||
| """XXX""" | ||
| from xml.sax.saxutils import escape |
Collaborator
There was a problem hiding this comment.
Huh, I thought I had already made this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some imports that aren't always needed to functions bodies. This
speeds up mypy startup by up to 120ms on my laptop (when not compiled).
Tests are a bit faster as well.