Second part of #6098 #6126
Merged
Second part of #6098 #6126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
approved these changes
Jan 2, 2019
| from typing import NamedTuple | ||
| from b import B | ||
|
|
||
| NT = NamedTuple('NT', [('x', B)]) |
Collaborator
There was a problem hiding this comment.
Maybe also try revealing the type of the x attribute?
Member
Author
There was a problem hiding this comment.
I added separate test (since reveal_type is an error and affects how targets are processed). This reminded me about an old question/TODO in typeanal.py. We still keep UnboundTypes in some places instead of replacing them with Any. Maybe we should stop doing this?(Note this requires updating many test cases.)
Collaborator
There was a problem hiding this comment.
Yeah, we should probably stop doing this at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes insufficient traversal of synthetic
TypeInfos in fine grained mode.