Micro-optimization of TypeInfo.__bool__ #5712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In conjunction with a change that makes mypyc able to directly generate calls to __bool__, this allows us to generate a much more direct check for truthiness of TypeInfo.
gvanrossum
approved these changes
Oct 1, 2018
TV4Fun
pushed a commit
to TV4Fun/mypy
that referenced
this pull request
Oct 4, 2018
In conjunction with a change that makes mypyc able to directly generate calls to `__bool__`, this allows us to generate a much more direct check for truthiness of TypeInfo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In conjunction with a change that makes mypyc able to directly
generate calls to
__bool__, this allows us to generate a much moredirect check for truthiness of TypeInfo.