Always initialize mro in TypeInfo #5472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the mro is left `None` to cause accesses to it before it is properly initialized to blow up more quickly. This sort of behavior doesn't play well with mypyc, and leaving it actually uninitialized causes a lot of blowups. Just always initialize mro to an empty list.
ilevkivskyi
approved these changes
Aug 14, 2018
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
I am fine with this. Could you please double check this with our internal code bases before merging?
Collaborator
Author
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the mro is left
Noneto cause accesses to it before it isproperly initialized to blow up more quickly. This sort of behavior
doesn't play well with mypyc, and leaving it actually uninitialized
causes a lot of blowups.
Just always initialize mro to an empty list.