[PEP 695] Fix a few issues and add tests #17318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
svalentin
approved these changes
Jun 3, 2024
| allow_placeholder=True, | ||
| declared_type_vars=type_params, | ||
| all_declared_type_params_names=all_type_params_names, | ||
| python_3_12_type_alias=True, |
Collaborator
There was a problem hiding this comment.
Should this always be True?
Collaborator
Author
There was a problem hiding this comment.
Yes, since the visit_type_alias_stmt method is specific to the 3.12 type alias statement. Other type aliases are handled elsewhere. I implemented this separately to avoid making the existing type alias logic even more complicated, since this looks like the end-game type alias implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix badly formed types that could be created when using aliases like
type A = list.Improve some error messages when using PEP 695 syntax.
Add a few PEP 695 tests.
Work on #15238.