Add check for comparisons like None in list/set/tuple
#17154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riables to not include None
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
…ed at the end of the if condition (preventing exceptions if right has no attribute "items")
…' into detect-None-in-default-iterables
This comment has been minimized.
This comment has been minimized.
Author
|
The new feature is ready and I tested it on all kinds of code samples, but something in the automatic tests that I added in the check-optional.test file got stuck. |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
Are there plans to merge this PR? Would be a great feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #17152
Fixes #17149
Summary
This PR adds to mypy the ability to recognize conditions like
if None in [a, b, c]:and refine the types ofa, b, cin the relevant scope. The supported expressions areListExpr, TupleExpr, SetExpr.