Skip to content

Check statements that are no-op for reachability #17080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Check statements that are no-op for reachability #17080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97c5eb4
Check no-op for reachability statements
hauntsaninja Mar 30, 2024
cad794a
Merge branch 'master' into check-unreachable-stmt
hauntsaninja Dec 27, 2024
5891d7c
callexpr
hauntsaninja Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions mypy/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,12 @@ def check_first_pass(self) -> None:
if self.binder.is_unreachable():
if not self.should_report_unreachable_issues():
break
if not self.is_noop_for_reachability(d):
if self.is_noop_for_reachability(d):
if not isinstance(d, ExpressionStmt) or not isinstance(
d.expr, CallExpr
):
self.accept(d)
else:
self.msg.unreachable_statement(d)
break
else:
Expand Down Expand Up @@ -2948,7 +2953,10 @@ def visit_block(self, b: Block) -> None:
if self.binder.is_unreachable():
if not self.should_report_unreachable_issues():
break
if not self.is_noop_for_reachability(s):
if self.is_noop_for_reachability(s):
if not isinstance(s, ExpressionStmt) or not isinstance(s.expr, CallExpr):
self.accept(s)
else:
self.msg.unreachable_statement(s)
break
else:
Expand Down
8 changes: 8 additions & 0 deletions test-data/unit/check-unreachable-code.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1505,6 +1505,14 @@ def f() -> Generator[None, None, None]:
return None
yield None

[case testErrorInNoopForReachabilityStatement]
# flags: --warn-unreachable
def double(x: int) -> int:
if not isinstance(x, int):
raise BaseException["Expected an integer"] # E: The type "Type[BaseException]" is not generic and not indexable
return x
[builtins fixtures/tuple.pyi]

[case testLambdaNoReturn]
# flags: --warn-unreachable
from typing import Callable, NoReturn
Expand Down
Loading