Skip to content

Conversation

@sobolevn
Copy link
Member

Explanation:

  • misc/async_matrix.py is tested in test-data/unit/check-async-await.test
  • misc/fix_annotate.py is not used, because python2 is not supported, type-comments are discussed to be deprecated as well (Deprecate type comment support? #12947), and lib2to3 is also deprecated and removed in recent python version
  • misc/remove-eol-whitespace.sh is not used, because we now have ruff / black and others to fix it

@hauntsaninja hauntsaninja merged commit 383137b into master Jul 20, 2023
@hauntsaninja hauntsaninja deleted the remove-unused-misc-scripts branch July 20, 2023 19:38
sobolevn added a commit that referenced this pull request Jul 29, 2023
It solves two problems:
1. `fix_annotate` and `async_matrix` were removed in
#15728
2. It is better to reuse stuff like `runtests.py` not to rewrite the
same command we already have

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants