attrs.evolve: support generics and unions #15050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikonst
force-pushed
the
2023-04-13-attrs-evolve-union
branch
from
be7ae9b to
aed08ca
Compare
ikonst
changed the title
ikonst
force-pushed
the
2023-04-13-attrs-evolve-union
branch
2 times, most recently
from
8c976f8 to
b32252f
Compare
This comment has been minimized.
This comment has been minimized.
ikonst
commented
Apr 13, 2023
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
ikonst
force-pushed
the
2023-04-13-attrs-evolve-union
branch
from
6721b51 to
8c90ab3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@hauntsaninja since you also reviewed #15022 I looked into existing code (checkmember, meet) but didn't find anything that did quite that, but |
Contributor
Author
|
👋 @hauntsaninja (trying to make it more readable, but it's really not too scary) |
This was referenced Apr 18, 2023
Closed
This comment has been minimized.
This comment has been minimized.
ikonst
force-pushed
the
2023-04-13-attrs-evolve-union
branch
from
857c624 to
10d9e91
Compare
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Overall seems reasonable, could you also add a test case for constrained type variables?
Contributor
Author
I believe there's already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
attrs.evolvesignature generation to support theinstparameter beingIn the case of unions, we "meet" the fields of the potential attrs classes, so that the resulting signature is the lower bound.
Fixes #15088.