Fix crash in match statement with unmatchable ClassPattern #13731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
force-pushed
the
fix-match-star
branch
from
f7d2f9c to
40edd4d
Compare
Collaborator
Author
|
Hmm, it looks like there are no test cases (other than the new one) that actually hit the can_match logic. Maybe we can just remove it? |
hauntsaninja
force-pushed
the
fix-match-star
branch
from
ac56c58 to
079a73d
Compare
Collaborator
Author
|
Okay, that seems to work and does simplify the code a little. I think there's some impact on reachability, but seemingly for the better in this case. |
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JelleZijlstra
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12886
contract_starred_pattern_typesandexpand_starred_pattern_typesare sort of like inverses of each other, so you get crashes ifcontracted_inner_typesandcontracted_new_inner_typesdon't correspond (in the case thatcan_matchgets set toFalse).WhenI'm not surecan_matchis False, we don't needcontracted_new_inner_types, so this PR just moves an if statement up a little bit and indent everything.can_matchis doing anything useful, so this PR now just gets rid of it.