Skip to content

Conversation

@KotlinIsland
Copy link
Contributor

@KotlinIsland KotlinIsland commented Mar 19, 2022

This fixes a test case, the test case included a sussy NBSP which resulted in the test being completely invalid.

I have now updated the testcase to vent the impostor and expect the correct result instead.

With nbsp:
x.trifdsgdfgm() # E: AMONGUS [attr-defined]

> pytest -n0 -k testEnableDifferentErrorCode
...
1 passed

with space:
x.trifdsgdfgm() # E: AMONGUS [attr-defined]

> pytest -n0 -k testEnableDifferentErrorCode
...

_____________________________________________________________________________________________________ testEnableDifferentErrorCode _____________________________________________________________________________________________________
data: /home/amongus/projects/mypy/test-data/unit/check-flags.test:1991:
/home/amongus/projects/mypy/mypy/test/testcheck.py:140: in run_case
    self.run_case_once(testcase)
/home/amongus/projects/mypy/mypy/test/testcheck.py:227: in run_case_once
    assert_string_arrays_equal(output, a, msg.format(testcase.file, testcase.line))
E   AssertionError: Unexpected type checker output (/home/amongus/projects/mypy/test-data/unit/check-flags.test, line 1991)
--------------------------------------------------------------------------------------------------------- Captured stderr call ---------------------------------------------------------------------------------------------------------
Expected:
  main:3: error: AMONGUS [attr-defined]         (diff)
Actual:
  (empty)

======================================================================================================= short test summary info ========================================================================================================
FAILED mypy/test/testcheck.py::TypeCheckSuite::check-flags.test::testEnableDifferentErrorCode

@KotlinIsland KotlinIsland changed the title Remove sussy NBSP from test case Vent sussy NBSP from test case Mar 19, 2022
@github-actions

This comment has been minimized.

1 similar comment
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@97littleleaf11 97littleleaf11 merged commit 8c8d169 into python:master Mar 19, 2022
@KotlinIsland KotlinIsland deleted the fix_space branch March 19, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants