add test for new union syntax on generic bounds #11431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
approved these changes
Nov 1, 2021
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Great, thank you very much! :-)
Contributor
Author
|
@hauntsaninja i'm not sure why the 3.10 tests are failing because it works when i run the same code locally. i assume 3.9 and below are failing because this new union syntax is only enabled in 3.10, so i moved the test to the newly created |
Member
|
This looks like a fixture issue to me. You may need a different one. See https://github.com/python/mypy/blob/master/test-data/unit/README.md#fixtures for an intro to fixtures. |
Contributor
Author
|
i can't seem to find a fixture that works, i thought maybe |
sobolevn
reviewed
Nov 3, 2021
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10949