Skip to content

dmypy - warn instead of failing if report generation is configured #10181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 19, 2022
Merged

dmypy - warn instead of failing if report generation is configured #10181

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
66dc5d3
dmypy - warn instead of failing if report generation is configured bu…
natemcmaster Feb 22, 2021
4959a21
Updating for PR feedback
natemcmaster May 4, 2021
a1849fe
Merge branch 'python:master' into dmypy-reports
natemcmaster May 7, 2021
c301748
Merge branch 'python:master' into dmypy-reports
natemcmaster May 24, 2021
5ae0743
Update dmypy_server.py
natemcmaster May 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions mypy/dmypy_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,11 @@ def process_start_options(flags: List[str], allow_sources: bool) -> Options:
['-i'] + flags, require_targets=False, server_options=True
)
if options.report_dirs:
sys.exit("dmypy: start/restart cannot generate reports")
print("dmypy: Ignoring report generation settings. Start/restart cannot generate reports.")
if options.junit_xml:
sys.exit("dmypy: start/restart does not support --junit-xml; "
"pass it to check/recheck instead")
print("dmypy: Ignoring report generation settings. "
"Start/restart does not support --junit-xml. Pass it to check/recheck instead")
options.junit_xml = None
if not options.incremental:
sys.exit("dmypy: start/restart should not disable incremental mode")
if options.follow_imports not in ('skip', 'error', 'normal'):
Expand Down