Coverage tests fail on Python 3.7+

[jaraco]

In GitLab by @jaraco on Apr 11, 2020, 17:29

Although CI doesn't run coverage on Python 3.7+, the tests are failing if run on those later versions.

I'm not sure what's the right course of action. I don't want to repeat the existing pattern and create a _py37.py to contain the select code that's run on Python 3.7+.

[jaraco]

In GitLab by @jaraco on Apr 11, 2020, 17:30

Here's what's not covered:

importlib_resources master $ tox -e py37-cov
py37-cov develop-inst-noop: /Users/jaraco/code/public/importlib_resources
py37-cov installed: coverage==5.0.4,importlib-metadata==1.6.0,-e git+gl://python-devs/importlib_resources@6114970c19a7f748d2e5c9744bb3d992c9175ec7#egg=importlib_resources,zipp==3.1.0
py37-cov run-test-pre: PYTHONHASHSEED='919679085'
py37-cov run-test: commands[0] | python -m unittest discover
........................................................................................................
----------------------------------------------------------------------
Ran 104 tests in 0.023s

OK
py37-cov run-test: commands[1] | python -m coverage run --rcfile=/Users/jaraco/code/public/importlib_resources/coverage.ini -m unittest discover
........................................................................................................
----------------------------------------------------------------------
Ran 104 tests in 0.029s

OK
py37-cov run-test: commands[2] | python -m coverage combine --rcfile=/Users/jaraco/code/public/importlib_resources/coverage.ini
py37-cov run-test: commands[3] | python -m coverage html --rcfile=/Users/jaraco/code/public/importlib_resources/coverage.ini
py37-cov run-test: commands[4] | python -m coverage xml --rcfile=/Users/jaraco/code/public/importlib_resources/coverage.ini
py37-cov run-test: commands[5] | python -m coverage report -m --rcfile=/Users/jaraco/code/public/importlib_resources/coverage.ini --fail-under=100
Name                             Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------------------
importlib_resources/_common.py      38     15      0      0    61%   18-19, 27-28, 32-39, 66-67, 76
importlib_resources/_py3.py         99      6     24      4    90%   92->93, 93-94, 95->100, 100, 135, 179->181, 181, 201->203, 203
importlib_resources/trees.py         2      0      0      0   100%
----------------------------------------------------------------------------
TOTAL                              139     21     24      4    83%
ERROR: InvocationError for command /Users/jaraco/code/public/importlib_resources/.tox/py37-cov/bin/python -m coverage report -m --rcfile=/Users/jaraco/code/public/importlib_resources/coverage.ini --fail-under=100 (exited with code 2)
________________________________________________________________________________ summary _________________________________________________________________________________
ERROR:   py37-cov: commands failed

[jaraco]

In GitLab by @brettcannon on Apr 14, 2020, 15:34

Could we set a goal of 80% and be done with it? Otherwise marking the version-specific branches or amalgamating all the runs into a single report is the only way to hit 100%.

[jaraco]

In GitLab by @jaraco on Jun 7, 2020, 18:27

It gets worse when I start backporting the functionality from Python 3.9. I'm going to lower the limit to 70% in order to get things passing and to allow coverage tests to run on modern Pythons.

[jaraco]

In GitLab by @jaraco on Jun 7, 2020, 18:29

mentioned in commit db1fa76

[jaraco]

In GitLab by @jaraco on Jun 7, 2020, 18:34

closed via merge request !100

[jaraco]

In GitLab by @jaraco on Jun 7, 2020, 18:34

mentioned in commit 2b4a476