Remove GNU make-specific directive from Makefile #1362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
commented
Aug 4, 2024
Comment on lines
+5
to
+15
| PYTHON = python3 | ||
| VENVDIR = ./venv | ||
| UV = uv | ||
| SPHINXBUILD = $(VENVDIR)/bin/sphinx-build | ||
| SPHINXOPTS = --fail-on-warning --keep-going | ||
| BUILDDIR = _build | ||
| BUILDER = html | ||
| JOBS = auto | ||
| PAPER = | ||
| SPHINXLINT = $(VENVDIR)/bin/sphinx-lint | ||
| REQUIREMENTS = requirements.txt |
There was a problem hiding this comment.
The main changes here are adding the UV and REQUIREMENTS lines.
The others have a space removed, so it's the same as the CPython/Docs and peps Makefiles and easier to diff.
AA-Turner
approved these changes
Aug 4, 2024
ezio-melotti
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like python/cpython#122662 and python/peps#3891.
This is mostly to keep the
Makefiles similar in each repo to ease maintenance.Also remove the
make servestub, the target was removed in April 2022 in #826.📚 Documentation preview 📚: https://cpython-devguide--1362.org.readthedocs.build/