Skip to content

gh-99706: unicodeobject: Fix padding in PyASCIIObject.state #99707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2022
Merged

gh-99706: unicodeobject: Fix padding in PyASCIIObject.state #99707

merged 1 commit into from
Nov 24, 2022

Conversation

@davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Nov 22, 2022 •
edited by bedevere-bot
Loading

Increase padding by 1 bit so that total bitfield size is 32 bits, as the fact the fields currently sum to 31 looks potentially unintended to me.

@bedevere-bot bedevere-bot mentioned this pull request Nov 22, 2022
Closed
kumaraditya303
kumaraditya303 approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@methane methane added skip news type-bug An unexpected behavior, bug, or error labels Nov 24, 2022
@methane methane changed the title gh-99706: unicodeobject - PyASCIIObject state to 32 bits gh-99706: unicodeobject: Fix padding in PyASCIIObject.state Nov 24, 2022
@methane methane merged commit b4d54a3 into python:main Nov 24, 2022
@methane
Copy link
Member

methane commented Nov 24, 2022

Thanks.

@iritkatriel iritkatriel mentioned this pull request Nov 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@methane methane Awaiting requested review from methane

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davidhewitt @methane @kumaraditya303 @bedevere-bot