Skip to content

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Oct 10, 2022

Remove abitype.py and pep384_macrocheck.py scripts of Tools/scripts/.

Remove abitype.py and pep384_macrocheck.py scripts of Tools/scripts/.
@vstinner
Copy link
Member Author

Remove abitype.py and pep384_macrocheck.py scripts of Tools/scripts/.

@encukou @erlend-aasland @corona10: Did one of you ever use one of these scripts? If not, I don't think that they are still relevant.

I didn't know these scripts but I ported many C extensions to heap types, module state and multi-phase init API. I was fine to do a few changes manually.

@erlend-aasland
Copy link
Contributor

Did one of you ever use one of these scripts?

I know about their existence, and I've had a look at them, but I've never used them. Porting C extension modules to module state is not straight-forward.

@encukou
Copy link
Member

encukou commented Oct 11, 2022

I've never used them. They seem untested and unused. Let's remove them and if anyone complains, improve them or add the check to CI.

@vstinner vstinner merged commit 454a6d6 into python:main Oct 11, 2022
@vstinner vstinner deleted the remove_pep384_scripts branch October 11, 2022 11:19
@vstinner
Copy link
Member Author

Ok, I removed them. As written in the doc, a copy can be found in the https://github.com/gvanrossum/old-demos project.

Doc: https://docs.python.org/dev/whatsnew/3.12.html#demos-and-tools

I've never used them. They seem untested and unused. Let's remove them and if anyone complains, improve them or add the check to CI.

Right, no doc, no test.

@corona10
Copy link
Member

Oh, I am late, but I never used them. I even don't know their existence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants